refactor: Optimize required_columns from BTreeSet to Vec in struct PushdownChecker
#19678
+21
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @kosiew |
kumarUjjawal
force-pushed
the
refactor/btree_to_vec
branch
from
9e5d7ba to
8c2462e
Compare
kosiew
reviewed
Jan 12, 2026
Contributor
kosiew
left a comment
kosiew
left a comment
There was a problem hiding this comment.
Thanks @kumarUjjawal for contributing.
I left some comments for your consideration.
| Unsupported, | ||
| } | ||
|
|
||
| #[derive(Debug)] |
Contributor
There was a problem hiding this comment.
Is there a reason to remove
#[derive(Debug)]
?
Comment on lines
310
to
312
| if !self.required_columns.contains(&idx) { | ||
| self.required_columns.push(idx); | ||
| } |
Contributor
There was a problem hiding this comment.
I think it would help future contributors to
- Add comment explaining linear search is acceptable for small
n- OR switch to
HashSetfor O(1) deduplication ifnmight grow
- OR switch to
Comment on lines
415
to
418
| let prevents_pushdown = checker.prevents_pushdown(); | ||
| let nested = checker.nested_behavior; | ||
| let mut required_columns = checker.required_columns; | ||
| required_columns.sort_unstable(); |
Contributor
There was a problem hiding this comment.
how about adding:
impl PushdownChecker {
fn into_sorted_columns(mut self) -> PushdownColumns {
self.required_columns.sort_unstable();
self.required_columns.dedup(); // this removes the need for contains check
PushdownColumns {
required_columns: self.required_columns,
nested: self.nested_behavior,
}
}
Comment on lines
419
to
422
| Ok((!prevents_pushdown).then_some(PushdownColumns { | ||
| required_columns, | ||
| nested, | ||
| })) |
Contributor
There was a problem hiding this comment.
and then rewriting this to:
Ok((!checker.prevents_pushdown())
.then_some(checker.into_sorted_columns()))
Comment on lines
310
to
312
| if !self.required_columns.contains(&idx) { | ||
| self.required_columns.push(idx); | ||
| } |
Contributor
There was a problem hiding this comment.
see suggested
fn into_sorted_columns
below
Contributor
Author
Thanks for the feedback. Incorporated the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
required_columnsfromBTreeSet<usize>toVec<usize>in struct PushdownChecker<'schema> #19673.Rationale for this change
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?